Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loadbalancer] unexport MetricsViews function #26992

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/checkapi/allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exporter/dynatraceexporter
exporter/f5cloudexporter
exporter/kafkaexporter
exporter/kineticaexporter
exporter/loadbalancingexporter
exporter/logzioexporter
exporter/lokiexporter
exporter/pulsarexporter
Expand Down
2 changes: 1 addition & 1 deletion exporter/loadbalancingexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

// NewFactory creates a factory for the exporter.
func NewFactory() exporter.Factory {
_ = view.Register(MetricViews()...)
_ = view.Register(metricViews()...)

return exporter.NewFactory(
metadata.Type,
Expand Down
4 changes: 2 additions & 2 deletions exporter/loadbalancingexporter/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ var (
successFalseMutator = tag.Upsert(tag.MustNewKey("success"), "false")
)

// MetricViews return the metrics views according to given telemetry level.
func MetricViews() []*view.View {
// metricViews return the metrics views according to given telemetry level.
func metricViews() []*view.View {
return []*view.View{
{
Name: mNumResolutions.Name(),
Expand Down
2 changes: 1 addition & 1 deletion exporter/loadbalancingexporter/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestProcessorMetrics(t *testing.T) {
"loadbalancer_backend_latency",
}

views := MetricViews()
views := metricViews()
for i, viewName := range expectedViewNames {
assert.Equal(t, viewName, views[i].Name)
}
Expand Down
Loading