[receiver/hostmetrics] Add optional system.linux.memory.available metric #27247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
approved these changes
Sep 27, 2023
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
…tadata.yaml Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
crobert-1
approved these changes
Sep 28, 2023
|
Hi folks, gentle ping on this one :) IIUC I'm only missing one more LGTM - whom should I ask for that? |
|
@dmitryax should review as code owner when possible. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
approved these changes
Nov 19, 2023
atoulme
added
the
ready to merge
codeboten
approved these changes
Nov 23, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…ric (open-telemetry#27247) Implement a new metric `system.linux.memory.available`, which I defined in open-telemetry/semantic-conventions#257. **Link to tracking Issue:** open-telemetry#7417 **Testing:** added a check to an existing unit test. I had to refactor the test a bit: it assumed that a certain metric will be at position 0, which is not true now. **Documentation:** Added note in `metadata.yaml` --------- Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
dmitryax
pushed a commit
that referenced
this pull request
Dec 8, 2023
There were some linting failures introduced in #27247. These are Windows and any non-Linux OS-specific linting failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Implement a new metric
system.linux.memory.available, which I defined in open-telemetry/semantic-conventions#257.Link to tracking Issue: #7417
Testing: added a check to an existing unit test. I had to refactor the test a bit: it assumed that a certain metric will be at position 0, which is not true now.
Documentation: Added note in
metadata.yaml