Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/syslog]: fix default behaviour (disable tls and use proper defaults) #27424

Merged

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Oct 4, 2023

Description:

  • fix defaults
  • fix some typos
  • correctly handle data structures which are output of syslog receiver
  • allow to not use tls and disable it by default

Link to tracking Issue: #25114

Testing:
Unit tests

Documentation:
N/A

@sumo-drosiek sumo-drosiek force-pushed the drosiek-syslog-defaults branch from cf9e4e5 to 9dcfbb1 Compare October 5, 2023 08:54
Dominik Rosiek added 6 commits October 5, 2023 10:55
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-syslog-defaults branch from 9dcfbb1 to dc90d91 Compare October 5, 2023 08:56
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I can see the date format for RFC 3164 was wrong and is fixed here. Thanks!

@djaglowski djaglowski merged commit 14375a3 into open-telemetry:main Oct 5, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 5, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-syslog-defaults branch October 9, 2023 06:38
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…defaults) (open-telemetry#27424)

**Description:**

- fix defaults
- fix some typos
- correctly handle data structures which are output of syslog receiver
- allow to not use tls and disable it by default

**Link to tracking Issue:** open-telemetry#25114 

**Testing:** 
Unit tests

**Documentation:** 
N/A

---------

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants