Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/cassandra] Added authorization by username and password #27841

Merged
merged 26 commits into from
Jan 15, 2024
Merged

[exporter/cassandra] Added authorization by username and password #27841

merged 26 commits into from
Jan 15, 2024

Conversation

go-follow
Copy link
Contributor

Description:
Added authorization by username and password for the Casandra exporter

Link to tracking Issue: #27827

Testing:

Documentation:

@go-follow go-follow requested a review from atoulme as a code owner October 18, 2023 13:03
@go-follow go-follow requested a review from a team October 18, 2023 13:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

crobert-1
crobert-1 reviewed Oct 18, 2023
View reviewed changes
exporter/cassandraexporter/config.go Outdated Show resolved Hide resolved
exporter/cassandraexporter/exporter_traces.go Outdated Show resolved Hide resolved
go-follow and others added 2 commits October 19, 2023 09:00
@go-follow @crobert-1
Update exporter/cassandraexporter/config.go
ef40980 
Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
@go-follow
add using configopaque.String instead string for auth.password
7ee9b3d
@atoulme
Copy link
Contributor

atoulme commented Oct 19, 2023

Needs test and a changelog - see the failing changelog build for steps.

@go-follow
Copy link
Contributor Author

Needs test and a changelog - see the failing changelog build for steps.

I did it

atoulme
atoulme approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Nov 8, 2023

Please rebase.

@go-follow go-follow requested a review from a team November 9, 2023 05:33
go-follow and others added 8 commits November 18, 2023 12:31
@go-follow @crobert-1
Update exporter/cassandraexporter/config.go
2c04534 
Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
@go-follow
add using configopaque.String instead string for auth.password
c2492f0
@go-follow
[exporter/cassandra] add test for authorization
d77c91a
@go-follow
add .chologgen/cassandraexporter-add-authorization.yaml
7fd8aba
@go-follow
add using configopaque.String instead string for auth.password
ed75f9e
@go-follow
Merge remote-tracking branch 'origin/exporter/cassandra/added-authori…
6c771e1 
…zation' into exporter/cassandra/added-authorization

# Conflicts:
#	exporter/cassandraexporter/config.go
#	exporter/cassandraexporter/go.mod
#	exporter/cassandraexporter/go.sum
@go-follow
Merge branch 'main' into exporter/cassandra/added-authorization
54f14b7
@go-follow
[exporter/cassandra] add check fill auth.username and auth.password
7b643bd
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 9, 2023
@crobert-1 crobert-1 removed the Stale label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@fatsheep9146
Copy link
Contributor

@go-follow please fix the conflict

@github-actions github-actions bot removed the Stale label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 10, 2024
@crobert-1 crobert-1 removed the Stale label Jan 10, 2024
@go-follow
Merge remote-tracking branch 'remote-origin/main' into exporter/cassa…
7764cbb 
…ndra/added-authorization

# Conflicts:
#	exporter/cassandraexporter/README.md
#	exporter/cassandraexporter/config.go
#	exporter/cassandraexporter/exporter_logs.go
#	exporter/cassandraexporter/exporter_traces.go
#	exporter/cassandraexporter/go.mod
#	exporter/cassandraexporter/go.sum
@go-follow
fix conflicts
6ad5050
@go-follow
Copy link
Contributor Author

@go-follow please fix the conflict

I'm sorry I wasn't active. I was very busy...

@fatsheep9146
Copy link
Contributor

@go-follow please fix the conflict

I'm sorry I wasn't active. I was very busy...

Thanks for your time!

@fatsheep9146
Copy link
Contributor 

--- a/exporter/cassandraexporter/go.mod
+++ b/exporter/cassandraexporter/go.mod
@@ -7,7 +7,7 @@ require (
 	github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal v0.92.0
 	github.com/stretchr/testify v1.8.4
 	go.opentelemetry.io/collector/component v0.92.1-0.20240112172857-83d[46](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7518433545/job/20467917191?pr=27841#step:3:47)3ceba06
-	go.opentelemetry.io/collector/config/configopaque v0.92.0
+	go.opentelemetry.io/collector/config/configopaque v0.92.1-0.20240112172857-83d463ceba06
 	go.opentelemetry.io/collector/confmap v0.92.1-0.20240112172857-83d463ceba06
 	go.opentelemetry.io/collector/exporter v0.92.1-0.20240112172857-83d463ceba06
 	go.opentelemetry.io/collector/pdata v1.0.2-0.20240112172857-83d463ceba06

There only one problem needs to be fixed. @go-follow Feel free to fix it when you have time.

@codeboten codeboten merged commit 3d84fbd into open-telemetry:main Jan 15, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 15, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@go-follow @crobert-1 @cparkins
[exporter/cassandra] Added authorization by username and password (op…
e610839 
…en-telemetry#27841)

Added authorization by username and password for the Casandra exporter

Fixes open-telemetry#27827

---------

Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@codeboten codeboten codeboten approved these changes

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@dashpole dashpole Awaiting requested review from dashpole

@jmacd jmacd Awaiting requested review from jmacd

@dmitryax dmitryax Awaiting requested review from dmitryax

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@mx-psi mx-psi Awaiting requested review from mx-psi

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@evan-bradley evan-bradley Awaiting requested review from evan-bradley

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@jsuereth jsuereth Awaiting requested review from jsuereth

@arminru arminru Awaiting requested review from arminru

@songy23 songy23 Awaiting requested review from songy23

Assignees

@djaglowski djaglowski

Labels
cmd/configschema configschema command cmd/githubgen cmd/mdatagen mdatagen command cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command exporter/cassandra
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.
6 participants
@go-follow @atoulme @fatsheep9146 @codeboten @crobert-1 @djaglowski