Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Move flush state into reader package #27843

Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Oct 18, 2023

Subset of #27823

This PR moves flush state to reader.Metadata. This works well because reader.Metadata is already intended for tracking file state. Flush state was previously tracked independently and loosely associated with a reader.

@djaglowski djaglowski force-pushed the pkg-stanza-metadata-flush branch from 151a3c7 to fc39539 Compare October 18, 2023 17:26
@djaglowski djaglowski marked this pull request as ready for review October 18, 2023 17:50
@djaglowski djaglowski requested review from a team and MovieStoreGuy October 18, 2023 17:50
@djaglowski djaglowski changed the title [pkg/stanza] Consolidate stateful split func into reader package [pkg/stanza] Move flush state into reader package Oct 18, 2023
@djaglowski djaglowski force-pushed the pkg-stanza-metadata-flush branch from fc39539 to 0a308a4 Compare October 19, 2023 18:15
@djaglowski djaglowski merged commit 24f1c59 into open-telemetry:main Oct 20, 2023
82 checks passed
@djaglowski djaglowski deleted the pkg-stanza-metadata-flush branch October 20, 2023 00:19
@github-actions github-actions bot added this to the next release milestone Oct 20, 2023
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants