[chore][pkg/stanza] Skip persister operations if nil #28580
Merged
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Oct 25, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…28580) Although the persister is generally expected, we can easily protect against cases where it is not provided and save some work as well. This becomes more important with open-telemetry#27823 which interacts with the persister during the Stop function.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…28580) Although the persister is generally expected, we can easily protect against cases where it is not provided and save some work as well. This becomes more important with open-telemetry#27823 which interacts with the persister during the Stop function.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…28580) Although the persister is generally expected, we can easily protect against cases where it is not provided and save some work as well. This becomes more important with open-telemetry#27823 which interacts with the persister during the Stop function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the persister is generally expected, we can easily protect against cases where it is not provided and save some work as well. This becomes more important with #27823 which interacts with the persister during the Stop function.