chore: add support for json codec in jaeger #28625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
add-json-jaeger-encoding
branch
from
c1733dc to
c989496
Compare
|
Changelog fails with: |
atoulme
reviewed
Oct 25, 2023
|
looks like great progress, I'd just not touch the marshaler for now, just add the JSON unmarshaler. |
VihasMakwana
force-pushed
the
add-json-jaeger-encoding
branch
3 times, most recently
from
30c4542 to
73033c9
Compare
atoulme
reviewed
Oct 26, 2023
VihasMakwana
force-pushed
the
add-json-jaeger-encoding
branch
3 times, most recently
from
d32f194 to
b1b6aed
Compare
|
@atoulme I think this is good to go! Can you review? |
atoulme
approved these changes
Oct 30, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme can we merge this? |
atoulme
added
the
ready to merge
This was referenced Nov 21, 2023
|
ah, we have a conflict now. Please rebase |
atoulme
removed
the
ready to merge
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
force-pushed
the
add-json-jaeger-encoding
branch
from
2c2ac15 to
b3dc4f4
Compare
atoulme
added
ready to merge
88 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Jan 8, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** Add support for JSON protocol for Jaeger codec. **Link to tracking Issue:** [open-telemetry#6272](open-telemetry#28686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support for JSON protocol for Jaeger codec.
Link to tracking Issue: #6272