[receiver/pulsarreceiver] enhance pulsar receiver #28681
Conversation
|
Also, now that we support OTLP Json and Protobuf, you might wanna tweak the test cases to make CI green. |
| - `zipkin_json`: the payload is deserialized into a list of Zipkin V2 JSON spans. | ||
| - `zipkin_thrift`: the payload is deserialized into a list of Zipkin Thrift spans. | ||
| - `consumer_name`: specifies the consumer name. | ||
| - `trace` |
There was a problem hiding this comment.
Why do we need to make this breaking change if we still want to migrate to the encoding extensions after that? I think it's better to avoid introducing this intermediary config interface.
Also, we need to try to avoid such breaking changes. Ideally, we need to keep the old interface functioning for some time with deprecation warning logs.
If you have any other changes not breaking the user config like refactoring, feel free to submit other PRs.
There was a problem hiding this comment.
The introduction of new encoding methods is only a small part of the reason, I created an issue for the PR #28685, please take a look.
The component currently in the Alpha phase, I think the configuration changes comply with the agreement.
There was a problem hiding this comment.
Even for alpha, we should try to avoid breaking changes if possible.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes: #28685
Description:
topic,subscription,encoding,consumer_nameconfiguration itemstrace,metric,logitemsotlp_jsonunmarshaler for traces,logs and metricsLink to tracking Issue:
Testing:
unit tests
Documentation:
Update README.md