-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update jaeger dep and remove koanf 1.5 dep #28881
[chore] update jaeger dep and remove koanf 1.5 dep #28881
Conversation
c7c88bd
to
d85f2a5
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
not stale, waiting on PR |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
d85f2a5
to
b76ea36
Compare
There's a change in jaeger v1.45.0 that causes the pkg/translator/jaeger test to fail:
@frzifus @yurishkuro it looks like maybe this change: jaegertracing/jaeger@0ee275a, any thoughts on how this test should change to address the failure? |
@codeboten yes, that's the change. It allows a lone follows-from reference to be treated as a parent. However, the OTLP span that the Jaeger span is compared against after translation does not define parent ID. The tests can be fixed with this change: diff --git a/pkg/translator/jaeger/jaegerproto_to_traces_test.go b/pkg/translator/jaeger/jaegerproto_to_traces_test.go
index 3ea43570d8..a75be85c87 100644
--- a/pkg/translator/jaeger/jaegerproto_to_traces_test.go
+++ b/pkg/translator/jaeger/jaegerproto_to_traces_test.go
@@ -919,6 +919,7 @@ func generateTracesTwoSpansWithFollower() ptrace.Traces {
span.SetName("operationC")
span.SetSpanID([8]byte{0x1F, 0x1E, 0x1D, 0x1C, 0x1B, 0x1A, 0x19, 0x18})
span.SetTraceID(spans.At(0).TraceID())
+ span.SetParentSpanID(spans.At(0).SpanID())
span.SetStartTimestamp(spans.At(0).EndTimestamp())
span.SetEndTimestamp(spans.At(0).EndTimestamp() + 1000000)
span.SetKind(ptrace.SpanKindConsumer) However, it would cause breaks in some other conversion tests, for the same reason - one side does not include the reference and/or ParentID. |
@yurishkuro after making the suggested change, the following error occurs, will fixing this require a change in ThriftToTraces to support this as well?
|
Fixes open-telemetry#28647 After this is merged contributors can finally use go workspaces in this repo. Signed-off-by: Alex Boten <aboten@lightstep.com>
1cd5d86
to
e18eb5d
Compare
Yes, I believe translation code is incorrect. For instance, in
Probably a similar issue in Thrift translation. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
Fixes #28647
After this is merged contributors can finally use go workspaces in this repo.
Fixes #26567