-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][receiver/journald] remove duplicate function NewFactory and pass checkapi #29005
[chore][receiver/journald] remove duplicate function NewFactory and pass checkapi #29005
Conversation
b824060
to
6fb32dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand what is being solved here.
Journald is a linux specific component, so this change introduces a factory for non-linux usage, but it does nothing? It seems like it. may cause other problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind my previous question. I understand the changes now.
b4e5b94
to
60623b4
Compare
Thanks for reviews @djaglowski! I should make it clear in the description that we should only keep one NewFactory. |
CI seems go wrong(seems not related with this PR), but i have no idea about that.
|
…ass checkapi Signed-off-by: sakulali <sakulali@126.com>
60623b4
to
d2951a5
Compare
…ass checkapi (open-telemetry#29005) **Description:** Remove duplicate function NewFactory and pass checkapi since we should only keep one NewFactory. **Link to tracking Issue:** open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . go test for journaldreceiver **Documentation:** Signed-off-by: sakulali <sakulali@126.com>
Description:
Remove duplicate function NewFactory and pass checkapi since we should only keep one NewFactory.
Link to tracking Issue:
#26304
Testing:
go run cmd/checkapi/main.go .
go test for journaldreceiver
Documentation: