[exporter/azuremonitor] Enhance AAD Documentation. #29234
Merged
+42
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntelemetry-collector-contrib into rajrang/aadEnhance
crobert-1
reviewed
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29234 +/- ##
==========================================
+ Coverage 82.64% 82.65% +0.01%
==========================================
Files 1749 1749
Lines 163368 163368
==========================================
+ Hits 135012 135031 +19
+ Misses 24453 24437 -16
+ Partials 3903 3900 -3 ☔ View full report in Codecov by Sentry. |
pcwiese
approved these changes
Nov 14, 2023
crobert-1
approved these changes
Nov 14, 2023
atoulme
approved these changes
Nov 14, 2023
|
@open-telemetry/collector-contrib-approvers Could you please help merge this PR, got an approval from the code owner. |
songy23
added
the
ready to merge
evan-bradley
approved these changes
Nov 15, 2023
|
@rajkumar-rangaraj We're currently performing a release. Once the release is over, I'll merge this. |
rajkumar-rangaraj
changed the title
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> * Update AAD documentation to use connection string instead of instrumentation key. Follow up to open-telemetry#28854 * Modified the ingestion version from 2.0 to 2.1 **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Existing tests. Output from manual run ``` json --------- Transmitting 30 items --------- {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Telemetry transmitted in 378.439395ms {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Response: 200 {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Items accepted/received: 30/30 {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} ``` **Documentation:** <Describe the documentation added.> * Updated Authentication.md
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> * Update AAD documentation to use connection string instead of instrumentation key. Follow up to open-telemetry#28854 * Modified the ingestion version from 2.0 to 2.1 **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Existing tests. Output from manual run ``` json --------- Transmitting 30 items --------- {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Telemetry transmitted in 378.439395ms {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Response: 200 {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} 2023-11-13T10:50:23.886-0800 debug azuremonitorexporter@v0.88.0/factory.go:139 Items accepted/received: 30/30 {"kind": "exporter", "data_type": "logs", "name": "azuremonitor"} ``` **Documentation:** <Describe the documentation added.> * Updated Authentication.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Existing tests.
Output from manual run
Documentation: