[chore][extension/observer] Assign exported function observer.NewEndpointsWatcher to a variable and pass checkapi
#29321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Nov 17, 2023
…pointsWatcher` to a variable and pass checkapi Signed-off-by: sakulali <sakulali@126.com>
sakulali
force-pushed
the
fix-observer-api
branch
from
e2d23f9 to
6f92deb
Compare
atoulme
reviewed
Nov 29, 2023
| @@ -31,7 +31,7 @@ type EndpointsWatcher struct { | |||
| logger *zap.Logger | |||
| } | |||
|
|
|||
| func NewEndpointsWatcher(endpointsLister EndpointsLister, refreshInterval time.Duration, logger *zap.Logger) *EndpointsWatcher { | |||
| var NewEndpointsWatcher = func(endpointsLister EndpointsLister, refreshInterval time.Duration, logger *zap.Logger) *EndpointsWatcher { | |||
There was a problem hiding this comment.
That's cheating :) there is no functional difference here. Since this is acting as a library, maybe we can discuss moving this to internal.
There was a problem hiding this comment.
Should i close or draft this PR since we maybe need to move this to internal?
There was a problem hiding this comment.
I'd close the PR. Thanks for the work on this, it's possible that moving the code to internal is rejected on the basis that this package is considered as a library, but not sure.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Assign exported function
observer.NewEndpointsWatcherto a variable and pass checkapi.Link to tracking Issue:
#26304
Testing:
go run cmd/checkapi/main.go .
go test for observer
go test for dockerobserver
go test for ecsobserver
go test for ecstaskobserver
go test for hostobserver
go test for k8sobserver
Documentation: