[chore] [translator/prometheusremotewrite] ensure unknown reset hint #29326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that native histogram reset hint is UNKNWON and document reasoning. Related: open-telemetry#28663 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dashpole
approved these changes
Nov 17, 2023
|
To other reviewers: This is a No-Op change, documenting why we are intentionally using the default value for the field to ensure we don't regress in the future. |
dashpole
added
chore
Skip Changelog
codeboten
approved these changes
Nov 17, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…pen-telemetry#29326) Ensure that native histogram reset hint is UNKNOWN and document reasoning. See discussion in the related PR: open-telemetry#28663 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure that native histogram reset hint is UNKNOWN and document reasoning.
See discussion in the related PR: #28663
Link to tracking Issue:
N/A
Testing:
N/A
Documentation:
N/A