[processor/resourcedetection] Add host.mac to system detector #29588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/metadataproviders
processor/resourcedetection
crobert-1
approved these changes
Nov 30, 2023
| // toIEEERA converts a MAC address to IEEE RA format. | ||
| // Per the spec: "MAC Addresses MUST be represented in IEEE RA hexadecimal form: as hyphen-separated | ||
| // octets in uppercase hexadecimal form from most to least significant." | ||
| // Golang returns MAC addresses as colon-separated octets in lowercase hexadecimal form from most |
There was a problem hiding this comment.
Just as a future reference for myself or others, I was wondering where this was documented/guaranteed, and found it in the implementation of String(). 👍
Co-authored-by: Curtis Robert <crobert@splunk.com>
atoulme
approved these changes
Dec 6, 2023
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
…elemetry#29588) **Description:** Adds support for `host.mac` detection to the `system` detector on the resource detection processor. This convention is defined in the specification [on the host document](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.1/docs/resource/host.md). **Link to tracking Issue:** Fixes open-telemetry#29587 and therefore fixes open-telemetry#22045 **Testing:** Unit tests; manually Tested on my laptop with the following configuration: ``` receivers: hostmetrics: collection_interval: 10s scrapers: load: processors: resourcedetection: detectors: ["system"] system: resource_attributes: host.mac: enabled: true exporters: debug: verbosity: detailed service: pipelines: metrics: receivers: [hostmetrics] processors: [resourcedetection] exporters: [debug] ``` --------- Co-authored-by: Curtis Robert <crobert@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for
host.macdetection to thesystemdetector on the resource detection processor.This convention is defined in the specification on the host document.
Link to tracking Issue: Fixes #29587 and therefore fixes #22045
Testing:
Unit tests; manually Tested on my laptop with the following configuration: