-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] use distributions.yaml in mdatagen #29851
[chore] use distributions.yaml in mdatagen #29851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: statusdata.go:14:12: pattern .distributions.yaml: no matching files found
7f4e30e
to
8967e9c
Compare
Also I am confused about the intent of the PR in general, why not using githubgen for this? Can you please clarify why we need this feature. |
We use the list of distributions to render the list with hyperlinks in the README of components presently. This closes the loop on the change, by adopting the distribution data from the yaml file as the source of truth for component distributions. This allows us to maintain distributions by editing distributions.yaml and see it reflected in all READMEs and distribution reports. See #29697 for context and #28628 for the original motivation. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@dmitryax please review as codeowner? |
How this change will play with the fact that mdatagen is moved to core? I think we need to start planning the deprecation and removal of this package from contrib |
you tell me :) |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Use the distributions.yaml introduced by #29697 to get the list of distributions.