[pkg/ottl] Update key.Name to be able to invoke a Getter #29883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
TylerHelmuth
added
the
Skip Changelog
evan-bradley
approved these changes
Dec 14, 2023
|
@evan-bradley I just made a significant change, please take another look |
evan-bradley
approved these changes
Dec 14, 2023
TylerHelmuth
changed the title
bogdandrutu
approved these changes
Dec 14, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…try#29883) **Description:** In order to support dynamic indexing we need the `key.Name` method to be able to invoke Getters during hot path execution. **Link to tracking Issue:** <Issue number if applicable> Related to open-telemetry#22744 **Testing:** <Describe what testing was performed and which tests were added.> Updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In order to support dynamic indexing we need the
key.Namemethod to be able to invoke Getters during hot path execution.Link to tracking Issue:
Related to #22744
Testing:
Updated tests