cmd/telemetrygen: Add headers to gRPC metadata for logs #30082
Conversation
metalmatze
requested review from
mx-psi,
codeboten and
a team
as code owners
| @@ -28,24 +29,32 @@ func newExporter(ctx context.Context, cfg *Config) (exporter, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| if !cfg.Insecure { | |||
| return nil, fmt.Errorf("'telemetrygen logs' only supports insecure gRPC") | |||
| // TODO: Use an otlplogs grpc package in the future | |||
There was a problem hiding this comment.
Can you file an issue for this, explaining why we can't do this yet?
There was a problem hiding this comment.
I wasn't able to find such a package. Does it exist?
There was a problem hiding this comment.
It does not, I just want to have an issue in this repository tracking this work, since TODOs are often missed :) You can just say "We should switch to opentelemetry-go logs exporter once available, see open-telemetry/opentelemetry-go#4696 for the current state"
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
I've pushed an update to this PR's branch. Can we open this PR again? |
|
@metalmatze Doesn't seem like I can :(
The aria label says "The telemetrygen-logs-grpc-metadata branch was force-pushed or recreated." Would you mind opening a new PR and pinging me there? |
**Description:** <Describe what has changed.> So far, sending (HTTP) headers along with gRPC requests hasn't been possible. For that reason, sending bearer tokens for authentication didn't work either. This is fixed now. Updated version of #30082 cc @mx-psi --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Description:
So far it wasn't possible to send (http) headers along with gRPC requests.
For that reason sending bearer tokens for authentication didn't work either.
This is fixed now.