Add AKS resource detector #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3035 +/- ##
==========================================
- Coverage 91.56% 91.55% -0.01%
==========================================
Files 466 468 +2
Lines 22998 23022 +24
==========================================
+ Hits 21057 21078 +21
- Misses 1445 1447 +2
- Partials 496 497 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Behavior tested on AKS, Azure VM, and Docker Desktop k8s.
jrcamp
reviewed
Apr 12, 2021
processor/resourcedetectionprocessor/internal/azure/aks/aks_test.go
Outdated
Show resolved
Hide resolved
|
Loadtest failed :-| |
jrcamp
approved these changes
Apr 12, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
* Add AKS resource detector Behavior tested on AKS, Azure VM, and Docker Desktop k8s. * Address PR feedback
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a resource detector for AKS. It checks for the presence of an env variable to determine if it's running on k8s, and attempts to retrieve data from the Azure IMDS endpoint to determine if it's running on Azure. If both conditions are met, it sets two Resource attributes. If not, no error is returned from the detector. Additionally, a change was made to the Azure detector to also not return an error when the IMDS endpoint is not available.
Behavior tested on AKS, Azure VM, and Docker Desktop k8s.