Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/basicauth] Accept empty usernames ; remove extra validation code #30470

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 12, 2024

Description:
Drop the validation that username is a required non-empty string.
Remove extraneous validation logic, use config.Validate

@atoulme atoulme changed the title [extension/basicauth] Remove extraneous validation logic [extension/basicauth] Accept empty usernames ; remove extra validation code Jan 12, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jan 22, 2024

@dmitryax ready to merge?

@jpkrohling jpkrohling merged commit 9ec687a into open-telemetry:main Jan 25, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 25, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…n code (open-telemetry#30470)

**Description:**
Drop the validation that username is a required non-empty string.
Remove extraneous validation logic, use config.Validate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants