-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl]Godoc comments #30564
Merged
Merged
[pkg/ottl]Godoc comments #30564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzmu
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
January 15, 2024 23:23
This is my first contribution, most of the public interfaces in [pkg/ottl] were already commented. Please let me know if I need to update anything. Thanks. |
fatsheep9146
added
the
Skip Changelog
PRs that do not require a CHANGELOG.md entry
label
Jan 16, 2024
fatsheep9146
approved these changes
Jan 16, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
crobert-1
reviewed
Jan 17, 2024
Co-authored-by: Curtis Robert <crobert@splunk.com>
TylerHelmuth
approved these changes
Jan 17, 2024
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** godoc comments added to non-commented public interfaces in [pkg/ottl] packages **Link to tracking Issue:** open-telemetry#28893 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: godoc comments added to non-commented public interfaces in [pkg/ottl] packages
Link to tracking Issue: #28893
Testing:
Documentation: