Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl]Godoc comments #30564

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Conversation

hamzmu
Copy link
Contributor

@hamzmu hamzmu commented Jan 15, 2024

Description: godoc comments added to non-commented public interfaces in [pkg/ottl] packages

Link to tracking Issue: #28893

Testing:

Documentation:

@hamzmu hamzmu requested a review from a team January 15, 2024 23:23
@hamzmu hamzmu changed the title Godoc comments [pkg/ottl]Godoc comments Jan 15, 2024
@hamzmu
Copy link
Contributor Author

hamzmu commented Jan 15, 2024

This is my first contribution, most of the public interfaces in [pkg/ottl] were already commented. Please let me know if I need to update anything. Thanks.

@fatsheep9146 fatsheep9146 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 16, 2024
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
pkg/ottl/expression.go Outdated Show resolved Hide resolved
hamzmu and others added 3 commits January 16, 2024 20:27
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@github-actions github-actions bot requested a review from kentquirk January 17, 2024 13:37
pkg/ottl/expression.go Outdated Show resolved Hide resolved
Co-authored-by: Curtis Robert <crobert@splunk.com>
Copy link
Contributor

github-actions bot commented Feb 1, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 1, 2024
@TylerHelmuth TylerHelmuth merged commit d9a5c38 into open-telemetry:main Feb 1, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
**Description:** godoc comments added to non-commented public interfaces
in [pkg/ottl] packages

**Link to tracking Issue:** open-telemetry#28893

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants