-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Validate queue settings implicitly. #30778
Merged
dmitryax
merged 7 commits into
open-telemetry:main
from
atoulme:validate_queue_implicitly
Feb 13, 2024
Merged
[chore] Validate queue settings implicitly. #30778
dmitryax
merged 7 commits into
open-telemetry:main
from
atoulme:validate_queue_implicitly
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… settings are indeed validated
dmitryax
reviewed
Jan 25, 2024
dmitryax
approved these changes
Jan 25, 2024
@dmitryax ok to merge? |
atoulme
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Feb 7, 2024
dmitryax
approved these changes
Feb 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Add a test checking queue settings are indeed validated. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test checking queue settings are indeed validated.