[system detector] Correctly report DRAGONFLYBSD value
#3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
+ Coverage 91.64% 91.66% +0.02%
==========================================
Files 482 482
Lines 23381 23385 +4
==========================================
+ Hits 21427 21437 +10
+ Misses 1454 1446 -8
- Partials 500 502 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Apr 14, 2021
bogdandrutu
approved these changes
Apr 14, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
This change contains a CLI tool, called 'docsgen', that generates markdown files for collector components. The markdown files present the configuration metadata extracted by the `configschema` API in a human readable form that can be used to manually configure the collector. This change also makes some modifications to the package formerly knows as `schemagen`, renaming it to `configschema` and exporting some things, because it no longer generates a schema yaml file, but rather provides an equivalent API used by docsgen. Also, this PR includes one sample, generated .md document: `receiver/otlpreceiver/config.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
dragonflyfamily. Not sure if the Collector would even build correctly on Dragonfly BSD but this is technically a bug 😄Link to tracking Issue: Relates to open-telemetry/opentelemetry-specification#1572
Testing: Added unit test