-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][mdatagen] Use MustNewType for metadata.Type #31038
Merged
mx-psi
merged 3 commits into
open-telemetry:main
from
mx-psi:mx-psi/mdatagen-mustnewtype
Feb 6, 2024
Merged
[chore][mdatagen] Use MustNewType for metadata.Type #31038
mx-psi
merged 3 commits into
open-telemetry:main
from
mx-psi:mx-psi/mdatagen-mustnewtype
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Feb 5, 2024
dmitryax
approved these changes
Feb 5, 2024
andrzej-stencel
approved these changes
Feb 5, 2024
MovieStoreGuy
approved these changes
Feb 6, 2024
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…1038) **Description:** Follow up to open-telemetry/opentelemetry-collector/pull/9414, adds the same changes in `mdatagen` regarding validation of `component.Type`s. On this PR the validation logic and templating is a bit more complex because of subcomponents. I will add these changes back on core once this PR is merged. **Link to tracking Issue:** open-telemetry/opentelemetry-collector/issues/9208
mx-psi
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 6, 2024
**Description:** Follow up to #9414 and open-telemetry/opentelemetry-collector-contrib/pull/31038. **Link to tracking Issue:** Fixes #9208.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/mdatagen
mdatagen command
connector/count
connector/datadog
connector/exceptions
connector/failover
connector/routing
connector/servicegraph
connector/spanmetrics
exporter/alertmanager
exporter/alibabacloudlogservice
Alibaba components
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
exporter/awsemf
awsemf exporter
exporter/awskinesis
exporter/awss3
exporter/awsxray
exporter/azuredataexplorer
exporter/azuremonitor
exporter/carbon
exporter/cassandra
exporter/clickhouse
exporter/coralogix
exporter/datadog
Datadog components
exporter/dataset
exporter/dynatrace
exporter/elasticsearch
exporter/f5cloud
F5 exporter
exporter/file
exporter/googlecloud
exporter/googlecloudpubsub
exporter/googlemanagedprometheus
Google Managed Prometheus exporter
exporter/honeycombmarker
exporter/influxdb
exporter/instana
exporter/kafka
exporter/kinetica
exporter/loadbalancing
exporter/logicmonitor
exporter/logzio
exporter/loki
Loki Exporter
exporter/mezmo
exporter/opencensus
exporter/opensearch
exporter/otelarrow
exporter/prometheus
exporter/prometheusremotewrite
exporter/pulsar
exporter/sapm
exporter/sentry
exporter/signalfx
exporter/skywalking
exporter/splunkhec
exporter/sumologic
exporter/syslog
exporter/tencentcloudlogservice
exporter/zipkin
extension/asapauth
extension/awsproxy
extension/basicauth
extension/bearertokenauth
extension/encoding
extension/headerssetter
extension/healthcheck
Health Check Extension
extension/httpforwarder
extension/jaegerremotesampling
extension/oauth2clientauth
extension/observer
extension/oidcauth
extension/opamp
extension/pprof
extension/remotetap
extension/sigv4auth
extension/solarwindsapmsettings
extension/storage
extension/sumologic
processor/attributes
Attributes processor
processor/cumulativetodelta
Cumulative To Delta processor
processor/datadog
processor/deltatocumulative
processor/deltatorate
Delta To Rate processor
processor/filter
Filter processor
processor/groupbyattrs
Group By Attributes processor
processor/groupbytrace
Group By Trace processor
processor/interval
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to open-telemetry/opentelemetry-collector/pull/9414, adds the same changes in
mdatagen
regarding validation ofcomponent.Type
s.On this PR the validation logic and templating is a bit more complex because of subcomponents. I will add these changes back on core once this PR is merged.
Link to tracking Issue: open-telemetry/opentelemetry-collector/issues/9208