Send log record name as part of the HEC log event #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3119 +/- ##
==========================================
+ Coverage 91.59% 91.61% +0.01%
==========================================
Files 486 486
Lines 23519 23521 +2
==========================================
+ Hits 21543 21549 +6
+ Misses 1466 1463 -3
+ Partials 510 509 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@tigrannajaryan @bogdandrutu PTAL and merge if looks good to you |
bogdandrutu
approved these changes
Apr 15, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
* Send log record name as part of the HEC log event * do not add the name label if its value is empty * Fix tests expecting a name label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Maps the logRecord name to a field sent as part of the HEC log event.
Link to tracking Issue:
Fixes #2685
Testing:
Unit testing.
Documentation:
None.