Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Add clarifications on serviceAccount auth type #31280

Merged

Conversation

ChrsMark
Copy link
Member

Description:

This PR adds some clarifications in the documentation of the serviceAccount auth type of the kubeletstats receiver.
This is an outcome of the discussions at open-telemetry/opentelemetry-helm-charts#1034 (comment).

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@TylerHelmuth TylerHelmuth added Skip Changelog PRs that do not require a CHANGELOG.md entry ready to merge Code review completed; ready to merge by maintainers labels Feb 20, 2024
@TylerHelmuth TylerHelmuth merged commit 62b8731 into open-telemetry:main Feb 21, 2024
150 of 152 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 21, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
open-telemetry#31280)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

This PR adds some clarifications in the documentation of the
`serviceAccount` auth type of the `kubeletstats` receiver.
This is an outcome of the discussions at
open-telemetry/opentelemetry-helm-charts#1034 (comment).

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark deleted the add_docs_for_kubelet_auth branch April 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/kubeletstats Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants