-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl]: Add ParseXML converter #31487
[pkg/ottl]: Add ParseXML converter #31487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from an xml parsing perspective
c0ae067
to
e87d96b
Compare
@TylerHelmuth @evan-bradley Any thoughts on this one? |
…ltiple XML payloads)
e0b874d
to
8fd0d3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evan-bradley please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Description:
Link to tracking Issue: Closes #31133
Testing:
Unit tests
Manually tested parsing XML logs
Documentation:
Added documentation for the ParseXML function to the ottl_funcs README.