Add container instance id as a placeholder #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3167 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 492 492
Lines 23692 23692
==========================================
- Hits 21755 21753 -2
- Misses 1432 1433 +1
- Partials 505 506 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hossain-rayhan
approved these changes
Apr 19, 2021
JohnWu20
force-pushed
the
AddContainerInstanceId
branch
from
3ae9be8 to
69d3f84
Compare
anuraaga
approved these changes
Apr 20, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
…y#3167) * Replace ReceiverCreateParams with ReceiverCreateSettings. Replace all dependencies in Receivers. Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # component/receiver.go # Conflicts: # exporter/opencensusexporter/opencensus_test.go # exporter/prometheusexporter/end_to_end_test.go * Update changelog Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Add missing file Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Replace ReceiverCreateParams with ReceiverCreateSettings. Replace all dependencies in Receivers. Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # component/receiver.go # Conflicts: # exporter/opencensusexporter/opencensus_test.go # exporter/prometheusexporter/end_to_end_test.go * Update changelog Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Add missing file Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AWS ECS container insights instance level metrics use ContainerInstanceId for the log stream name, so this pr is to add container instance id as a placeholder.
Allow to use ContainerInstanceId as placeholder in log group/stream name.
Add unit test for ContainerInstanceId placeholder.
Update tests and readme