[receiver/prometheusreceiver] Use Prometheus Labels public method API #31908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only using the public method API for Prometheus labels (rather than assuming `labels.Labels` is an alias of a slice) it opens up the possibility to build a collector with the `stringlabels` tag, so we can use the more memory efficient labels implementation.
braydonk
changed the title
dashpole
reviewed
Mar 22, 2024
|
I don't think there is. If there was an interface type or something, it would mean we could use that instead of The way it's implemented upstream, these public methods are sort of an unstated interface (if any methods don't exist in one version of the Labels implementation then the build wouldn't work anyway) so I think the best we can do at the moment is ensure that any interactions with the |
dashpole
approved these changes
Mar 22, 2024
krajorama
added a commit
to krajorama/opentelemetry-collector-contrib
that referenced
this pull request
Mar 27, 2024
Adopt open-telemetry#31908 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
By only using the public method API for Prometheus labels (rather than assuming
labels.Labelsis an alias of a slice) it opens up the possibility to build a collector with thestringlabelstag, so we can use the more memory efficient labels implementation.Link to tracking Issue:
#31907
Testing:
I had trouble running all of the tests locally, so I think I will need some help with making that work. I did run all the tests I changed with
-tags=stringlabelsand without it.Documentation:
Should not need any changes.