update otelcol versions to 0.98.0 #32544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
codeboten
approved these changes
Apr 18, 2024
|
Unfortunately, this works because the builder version is old...when updated to the newest commit hash, I see this error: |
|
@kristinapathak i've merged this anyways since it was left on the old version |
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Apr 19, 2024
#### Description When building from a commit hash, I got this error: ``` Error: mismatch in go.mod and builder configuration versions: core collector version calculated by component dependencies "v0.98.1-0.20240416174005-d0f15e2463f8" does not match configured version "v0.98.0". Use --skip-strict-versioning to temporarily disable this check. This flag will be removed in a future minor version ``` It may be more useful to only compare the major and minor versions #### Link to tracking issue #9896 Found in open-telemetry/opentelemetry-collector-contrib#32544 #### Testing Manually tested new build #### Documentation updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix versioning mismatch
Link to tracking Issue: 32539
Testing: ran
make genotelcontribcolandmake genoteltestbedcol