Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Take into account the ascending option when sorting by mtime #32820

Merged
merged 2 commits into from
May 2, 2024
Merged

[pkg/stanza] Take into account the ascending option when sorting by mtime #32820

merged 2 commits into from
May 2, 2024

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented May 2, 2024 •
edited
Loading

Description:

  • Allow ascending sort when sorting by mtime

Link to tracking Issue: Closes #32792

Testing:

  • Unit tests

@github-actions github-actions bot requested a review from djaglowski May 2, 2024 14:49
@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review May 2, 2024 14:54
@BinaryFissionGames BinaryFissionGames requested a review from a team May 2, 2024 14:54
@djaglowski djaglowski merged commit bea4bb1 into open-telemetry:main May 2, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
pkg/stanza
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.

ordering_criteria does not work for filelog receiver
3 participants
@BinaryFissionGames @djaglowski @MovieStoreGuy