Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for rabbitmq exporter #32856

Merged

Conversation

swar8080
Copy link
Contributor

@swar8080 swar8080 commented May 4, 2024

Description:
Adds integration test for the rabbitmq exporter. It tests the happy path and the logic for creating a new connection when the current one becomes unhealthy

@swar8080 swar8080 requested a review from a team as a code owner May 4, 2024 20:20
@swar8080 swar8080 requested a review from codeboten May 4, 2024 20:20
@swar8080 swar8080 force-pushed the rabbitmq_integration_tests branch 2 times, most recently from 5cfd6e4 to d7139cd Compare May 4, 2024 23:19
@swar8080 swar8080 changed the title Draft: Add integration test for rabbitmq exporter Add integration test for rabbitmq exporter May 5, 2024
@swar8080 swar8080 force-pushed the rabbitmq_integration_tests branch from 51ad944 to 9c73286 Compare May 12, 2024 13:34
@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 13, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 28, 2024
@crobert-1 crobert-1 removed the Stale label May 28, 2024
@atoulme
Copy link
Contributor

atoulme commented May 30, 2024

Please review the conflicts.

@swar8080 swar8080 requested a review from atoulme as a code owner May 31, 2024 01:18
@swar8080
Copy link
Contributor Author

All good to merge now @atoulme

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label May 31, 2024
@MovieStoreGuy MovieStoreGuy merged commit 7cc24ff into open-telemetry:main Jun 2, 2024
169 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/rabbitmq ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants