[cmd/opampsupervisor] Receive and report effective config #33462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Co-authored-by: Brandon Johnson <binaryfissiongames@gmail.com>
…ept-remote-config
…ept-remote-config
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
evan-bradley
approved these changes
Jun 11, 2024
|
I requested a review from everyone who had a review requested on the previous PR. I think I'm a little too close to this one, so I wouldn't mind a second pair of eyes. If nobody has comments by the end of the week, I'll merge this. |
djaglowski
approved these changes
Jun 11, 2024
…mpty onconnecting
…eyond composeMergedConfig)
…ept-remote-config
|
@tigrannajaryan I think I've got all your feedback incorporated, when you get a chance to take another pass. |
tigrannajaryan
approved these changes
Jun 12, 2024
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
|
Thanks @tigrannajaryan for the comprehensive review. The dual use of "effective config" was bothering me too, but I hadn't gone through and changed the usage everywhere. I like "merged config" to represent the config given to the Collector much more. |
|
Thank you @BinaryFissionGames for getting this across the finish line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the ability to receive and run remote configurations from an OpAMP server, as well as to report the remote configuration status.
This PR is just bringing #31641 up-to-date.
Link to tracking Issue: Resolves #30622
Testing:
Unit tests
Documentation: