Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][golangci-lint] Remove gosec excludes #33574

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Jun 14, 2024

Description:

The upstream issue was fixed by golangci/golangci-lint#4748, which was included in release v1.59.0 of golangci-lint. From local testing, we're pulling version v1.59.1 of golangci-lint, so the issue should be resolved.

Local runtime with excludes:

$ .tools/golangci-lint run -v --enable-only gosec
...
INFO Execution took 10.927544867s
INFO Execution took 8.011302204s
INFO Execution took 7.716441258s
INFO Execution took 7.441336833s

Local runtime without excludes:

$ .tools/golangci-lint run -v --enable-only gosec
...
INFO Execution took 9.780250262s
INFO Execution took 8.175492516s
INFO Execution took 7.550060974s
INFO Execution took 7.526585686s

Note: I ran .tools/golangci-lint cache clean between each test to clean the cache and keep results as consistent as possible. I admit that I don't know why the values keep going down with every run, the cache cleaning command may not entirely be working.

Link to tracking Issue:
These excludes were introduced in #33192
I've opened a PR in core for this issue as well: open-telemetry/opentelemetry-collector#10411

@crobert-1 crobert-1 requested review from a team and evan-bradley June 14, 2024 18:19
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jun 14, 2024
@codeboten codeboten merged commit d15830d into open-telemetry:main Jun 14, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants