[chore][golangci-lint] Remove gosec excludes #33574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The upstream issue was fixed by golangci/golangci-lint#4748, which was included in release
v1.59.0
ofgolangci-lint
. From local testing, we're pulling versionv1.59.1
ofgolangci-lint
, so the issue should be resolved.Local runtime with excludes:
Local runtime without excludes:
Note: I ran
.tools/golangci-lint cache clean
between each test to clean the cache and keep results as consistent as possible. I admit that I don't know why the values keep going down with every run, the cache cleaning command may not entirely be working.Link to tracking Issue:
These excludes were introduced in #33192
I've opened a PR in core for this issue as well: open-telemetry/opentelemetry-collector#10411