Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadogexporter] Add logging for unknown or unsupported metric types #3421

Merged
merged 2 commits into from
May 19, 2021
Merged

[datadogexporter] Add logging for unknown or unsupported metric types #3421

merged 2 commits into from
May 19, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 18, 2021

Description:

  • Add debug log for unsupported or unknown metric types to help with debugging and troubleshooting.

Link to tracking Issue: n/a

Testing: Amended unit tests.

@mx-psi
Copy link
Member Author

mx-psi commented May 18, 2021

cc @KSerrania to review

@mx-psi mx-psi marked this pull request as ready for review May 18, 2021 15:32
@mx-psi mx-psi requested a review from a team May 18, 2021 15:32
KSerrania
KSerrania approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it make sense to add a test with an unsupported metric type to check that the logger does log as expected?

@mx-psi
Copy link
Member Author

mx-psi commented May 19, 2021

@KSerrania done ✅

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label May 19, 2021
@bogdandrutu bogdandrutu merged commit 7e1bd79 into open-telemetry:main May 19, 2021
@mx-psi mx-psi deleted the mx-psi/log-warning branch May 20, 2021 07:19
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@bogdandrutu
Add comments to translation interfaces, clarify on error return value…
4c503dd 
… cannot be used (#3421)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mx-psi @bogdandrutu @KSerrania