Refactor AWS Kinesis exporter to allow for extended types of encoding #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
May 20, 2021
|
Please update the PR title to something more descriptive. "Main" does not tell what it does. |
MovieStoreGuy
changed the title
|
Sorry @mx-psi , @tigrannajaryan , it completely skip my mind. |
|
Hey @mx-psi , @tigrannajaryan , Could I kindly ask you to review this please? |
mx-psi
reviewed
May 26, 2021
| ) | ||
|
|
||
| var ( | ||
| // ErrUnsupportedEncodedType is used when the encoder type does not the type of encoding |
There was a problem hiding this comment.
Suggested change
| // ErrUnsupportedEncodedType is used when the encoder type does not the type of encoding | |
| // ErrUnsupportedEncodedType is used when the encoder type does not support the type of encoding |
added 5 commits
May 26, 2021 22:45
In order to make the transition from only jaeger traces to otlp data being written to kinesis, we've split up our approach and made sure it does not introduce breaking changes.
Adding in tests for the encoder to ensure the expected errors are being raised.
|
Sorry, need to close this PR to fix up how we are using our fork. |
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
…released (open-telemetry#3434) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
…released (#3434) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Moving to encoding type model for exporting data to kinesis while maintaining backwards comparability. Ref #1310
Link to tracking Issue: We have split up the work needed for #1305 as per @owais' comments on the PR linked above.
Testing: I have added rather trivial tests to get this shipped and to make sure it doing what it says on the tin (so to speak).
Documentation: No behaviour changes are being made here, just a change in implementation detail. Any follow up PRs that extend the ability of this exporter will joined with documentation.