Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog]: Add datadog span operation name remapping config option #3444

Merged

Conversation

ericmustin
Copy link
Contributor

Description:

This PR address discussion in #1909 , in which users generally find the converted Datadog Span Operation Name to be unhelpful, verbose, or otherwise difficult to work with. This PR adds a configuration option span_name_remappings which allows a user to pass a list of strings formatted <previous_span_operation_name> <updated_span_operation_name> so that they can convert their datadog span operation name to one they'd prefer.

Link to tracking Issue: #1909

Testing: Added unit tests and updated current tests

Documentation: This is documented in our example yaml configuration

@ericmustin ericmustin requested a review from mx-psi as a code owner May 20, 2021 22:10
@ericmustin ericmustin requested a review from a team May 20, 2021 22:10
@ericmustin ericmustin changed the title [exporter/datadog]; Add datadog span operation name remapping config option [exporter/datadog]: Add datadog span operation name remapping config option May 20, 2021
@mx-psi mx-psi assigned mx-psi and unassigned kbrockhoff May 21, 2021
exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
exporter/datadogexporter/translate_traces.go Outdated Show resolved Hide resolved
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for bearing with me and explaining why this is needed here. Just one minor thing and fix the merge conflict and we are good to go :)

exporter/datadogexporter/config/config.go Outdated Show resolved Hide resolved
@ericmustin
Copy link
Contributor Author

@mx-psi also added a bit of cleanup as we discussed around denylister and traceedgeconnection so that they're private

@ericmustin ericmustin requested a review from mx-psi June 2, 2021 17:27
@bogdandrutu bogdandrutu merged commit d152adf into open-telemetry:main Jun 3, 2021
@mx-psi mx-psi deleted the add_span_operation_name_mapping branch June 3, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants