-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog]: Add datadog span operation name remapping config option #3444
Merged
bogdandrutu
merged 13 commits into
open-telemetry:main
from
DataDog:add_span_operation_name_mapping
Jun 3, 2021
Merged
[exporter/datadog]: Add datadog span operation name remapping config option #3444
bogdandrutu
merged 13 commits into
open-telemetry:main
from
DataDog:add_span_operation_name_mapping
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
changed the title
[exporter/datadog]; Add datadog span operation name remapping config option
[exporter/datadog]: Add datadog span operation name remapping config option
May 20, 2021
mx-psi
reviewed
May 21, 2021
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
merge upstream
…opentelemetry-collector-contrib into add_span_operation_name_mapping merge upstream
mx-psi
reviewed
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for bearing with me and explaining why this is needed here. Just one minor thing and fix the merge conflict and we are good to go :)
@mx-psi also added a bit of cleanup as we discussed around |
mx-psi
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR address discussion in #1909 , in which users generally find the converted Datadog Span Operation Name to be unhelpful, verbose, or otherwise difficult to work with. This PR adds a configuration option
span_name_remappings
which allows a user to pass a list of strings formatted<previous_span_operation_name> <updated_span_operation_name>
so that they can convert their datadog span operation name to one they'd prefer.Link to tracking Issue: #1909
Testing: Added unit tests and updated current tests
Documentation: This is documented in our example yaml configuration