jmx receiver: allow setting system properties #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
May 21, 2021
receiver/jmxreceiver/config.go
Outdated
| @@ -59,6 +59,9 @@ type Config struct { | |||
| RemoteProfile string `mapstructure:"remote_profile"` | |||
| // The SASL/DIGEST-MD5 realm | |||
| Realm string `mapstructure:"realm"` | |||
| // Array of property=value strings to pass as system properties when running JMX Metric Gatherer | |||
| Properties []string `mapstructure:"properties"` | |||
There was a problem hiding this comment.
Any reason not to use a map[string]string here instead? That way you don't have to parse the configuration yourself
There was a problem hiding this comment.
viper is destructive in its case insensitivity and this avoid that issue: open-telemetry/opentelemetry-collector#2594
There was a problem hiding this comment.
I see. I don't have enough context to judge here but it feels like the correct solution would be to fix the issue above then instead of working around it (we don't expose Viper explicitly anymore so the issue can be addressed more easily).
There was a problem hiding this comment.
That sounds fair and I've updated to a map and will try to address the underlying issue in the core project.
rmfitzpatrick
force-pushed
the
jmx_receiver_system_properties
branch
from
52779c6 to
6573b48
Compare
rmfitzpatrick
force-pushed
the
jmx_receiver_system_properties
branch
from
6573b48 to
c20c3b3
Compare
mx-psi
approved these changes
May 24, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
During receiver shutdown discovery is stopped. However, any previously discovered targets will continue to be scraped. This calls `Stop` on the scrape manager to stop the scraping on shutdown as well. **Issue:** signalfx/splunk-otel-collector#471 **Testing:** - added check to Prometheus end to end test that scraping is actually stopped - tested end to end with receivercreator, saw that scraping actually stopped after pod was deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - These changes add a new
propertiesconfig option to allow specifying desired system properties for the groovy metric gathering script environment.Link to tracking Issue:
open-telemetry/opentelemetry-java-contrib#33
Testing:
Unit and integration tests added/updated.
Documentation:
Config field documentation added.