[receiver/sqlserver] Add computer name resource attribute to relevant metrics #35040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Sep 5, 2024
crobert-1
commented
Sep 5, 2024
djaglowski
approved these changes
Sep 6, 2024
atoulme
approved these changes
Sep 12, 2024
crobert-1
force-pushed
the
sqlserver_computer_rattr
branch
from
5e9701c
to
9453fd3
Compare
|
I've filed #35226 for the failing integration test, it's unrelated to this change. Adding |
crobert-1
added
the
ready to merge
pjanotti
approved these changes
Sep 26, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
… metrics (open-telemetry#35040) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The computer name resource attribute is relevant for all metrics coming from the SQL server receiver when directly connected to the DB. This change records the resource attribute with all remaining metrics that it wasn't recorded with yet. **Link to tracking Issue:** <Issue number if applicable> This was discovered at the same time as open-telemetry#35036, but I split out the changes to hopefully make them easier to review. **Testing:** <Describe what testing was performed and which tests were added.> Tests have been updated and are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The computer name resource attribute is relevant for all metrics coming from the SQL server receiver when directly connected to the DB. This change records the resource attribute with all remaining metrics that it wasn't recorded with yet.
Link to tracking Issue:
This was discovered at the same time as #35036, but I split out the changes to hopefully make them easier to review.
Testing:
Tests have been updated and are passing.