Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataDog exporter unit test which was failing when run on EC2 inst… #3528

Merged

Conversation

straussb
Copy link
Contributor

…ance development environment.

The test assumed that the EC2 Instance Metadata Service would not be accessible. Now disable it via environment
variable to enforce that assumption.

Description:

Link to tracking Issue: #3526

Testing:

Documentation:

@straussb straussb requested a review from mx-psi as a code owner May 25, 2021 20:31
@straussb straussb requested a review from a team May 25, 2021 20:31
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to kick the test i believe

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…ance development environment.

The test assumed that the EC2 Instance Metadata Service would not be accessible.  Now disable it via environment
variable to enforce that assumption.
@straussb straussb force-pushed the datadog-exporter-unit-test-fix branch from 75f2f77 to 08d389f Compare May 27, 2021 14:54
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label May 28, 2021
@bogdandrutu bogdandrutu merged commit 0bedbca into open-telemetry:main Jun 1, 2021
@straussb straussb deleted the datadog-exporter-unit-test-fix branch January 19, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants