[exporter/splunkhec] Fix Capabilities with enabled batching #35306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/splunkhec
pkg/batchperresourceattr
receiver/receivercreator
receiver/redis
dmitryax
force-pushed
the
fix-hec-exporter-mutability
branch
2 times, most recently
from
a04348d
to
58cd9b8
Compare
The exporter wrappers, like batch by scope and batch by resource, incorrectly claim that they are not mutating even if the wrapped exporter mutates the data. This leads to "invalid data access" runtime failures. This change fixes that.
dmitryax
force-pushed
the
fix-hec-exporter-mutability
branch
from
58cd9b8
to
2bdc029
Compare
atoulme
approved these changes
Sep 20, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…emetry#35306) The exporter wrappers, like batch by scope and batch by resource, incorrectly claim that they are not mutating even if the wrapped exporter mutates the data. This leads to "invalid data access" runtime failures. This change fixes that. Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter wrappers, like batch by scope and batch by resource, incorrectly claim that they are not mutating even if the wrapped exporter mutates the data. This leads to "invalid data access" runtime failures. This change fixes that.