Add semantic conventions to k8s-tagger for pod metadata #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
May 26, 2021
chaitanyaphalak
force-pushed
the
add-semantic-conventions-to-k8s-tagger
branch
2 times, most recently
from
ead35aa to
4ffcc87
Compare
|
Hey @owais i updated everything, the PR is ready for review :) |
owais
reviewed
May 28, 2021
chaitanyaphalak
force-pushed
the
add-semantic-conventions-to-k8s-tagger
branch
from
77cf481 to
395d00d
Compare
|
Hey @owais i updated you recent suggestions, the PR is ready for review :) |
owais
reviewed
Jun 1, 2021
owais
approved these changes
Jun 1, 2021
Aneurysm9
approved these changes
Jun 1, 2021
bogdandrutu
reviewed
Jun 2, 2021
|
@bogdandrutu ready for merge |
bogdandrutu
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Use semantic conventions to specify metadata for k8s-tagger
Link to tracking Issue: #3384
Testing: Updated unit tests