[chore] add remove-toolchain make cmd #35490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/oteltestbedcol
exporter/doris
cmd/otelcontribcol
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
force-pushed
the
toolchain-trial
branch
from
708b7b3
to
bd93fb3
Compare
This was referenced Sep 30, 2024
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
commented
Sep 30, 2024
cmd/otelcontribcol/go.mod
Outdated
| @@ -4,6 +4,8 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontrib | |||
|
|
|||
| go 1.22.0 | |||
|
|
|||
| toolchain go1.22.7 | |||
There was a problem hiding this comment.
left this in since this file will be removed with #34844 anyways and this also satisfies the pipeline
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mwear
approved these changes
Sep 30, 2024
|
I would expect this PR to also remove the toolchain directive from e.g. |
mx-psi
approved these changes
Oct 1, 2024
|
Thanks for explaining! |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds a new `remove-toolchain` make command which removes the `toolchain` directive from all go.mod files. The new make command is also added to the `update-otel` make target. **Link to tracking Issue:** <Issue number if applicable> - fixes open-telemetry#33600 - could potentially also work for open-telemetry#35160 **Testing:** <Describe what testing was performed and which tests were added.> - add a `toolchain go1.22.5` directive to any of the go.mod files in this repo - call `make remove-toolchain` - check if the toolchain directive was removed --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
|
fixes #35160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new
remove-toolchainmake command which removes thetoolchaindirective from all go.mod files.The new make command is also added to the
update-otelmake target.Link to tracking Issue:
make gotidyruns #35160Testing:
toolchain go1.22.5directive to any of the go.mod files in this repomake remove-toolchain