Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/sumologic] Add new products to auto discovery #35622

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[extension/sumologic] Add new products to auto discovery #35622

merged 1 commit into from
Nov 20, 2024

Conversation

chan-tim-sumo
Copy link
Contributor

@chan-tim-sumo chan-tim-sumo commented Oct 4, 2024 •
edited
Loading

Description

  • Added new products to auto discovery for the otel collector to detect the new processes running in the background.
[x] jmx
[x] activemq
[x] docker ce
[x] haproxy
[x] memcached
[x] mongodb
[x] cassandra
[x] microsoft sql server (linux)
[] oracledb (not including in this iteration)

Link to tracking issue

Testing

  • ran in staging/long env
  • Screenshots of the products showing up in COLLECTOR TAGS is in the jira.

Documentation

@chan-tim-sumo chan-tim-sumo requested a review from a team as a code owner October 4, 2024 19:08
songy23
songy23 reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts

Does this need a changelog?

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 19, 2024
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_autodiscovery branch 4 times, most recently from 07d0125 to 0801b46 Compare October 23, 2024 23:36
@chan-tim-sumo chan-tim-sumo requested a review from songy23 November 1, 2024 21:21
@chan-tim-sumo
Copy link
Contributor Author

@fatsheep9146 can you take a look at this PR as well?

@atoulme
Copy link
Contributor

atoulme commented Nov 12, 2024

Please resolve conflicts.

Given that this is specifically related to the sumologic extension, it would be great to get the codeowner's review - @rnishtala-sumo please review.

@chan-tim-sumo chan-tim-sumo mentioned this pull request Nov 13, 2024
Draft
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_autodiscovery branch 3 times, most recently from fc85b51 to 4465884 Compare November 14, 2024 19:25
fguimond
fguimond approved these changes Nov 15, 2024
View reviewed changes
Copy link

@fguimond fguimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrzej-stencel andrzej-stencel changed the title Added new products to auto discovery for sumo otel collector [exporter/sumologic] Add new products to auto discovery Nov 20, 2024
@andrzej-stencel andrzej-stencel changed the title [exporter/sumologic] Add new products to auto discovery [extension/sumologic] Add new products to auto discovery Nov 20, 2024
rnishtala-sumo
rnishtala-sumo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrzej-stencel andrzej-stencel merged commit 909c107 into open-telemetry:main Nov 20, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnishtala-sumo rnishtala-sumo rnishtala-sumo approved these changes

@songy23 songy23 songy23 approved these changes

@fguimond fguimond fguimond approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@songy23 songy23

Labels
exporter/rabbitmq exporter/sumologic extension/sumologic
Projects
None yet
Milestone
v0.115.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chan-tim-sumo @atoulme @fguimond @songy23 @rnishtala-sumo @andrzej-stencel