Remove skipping opencensus from goleak, no longer needed #35625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
atoulme,
a team,
fatsheep9146,
jpkrohling,
dashpole,
jsuereth and
dmitryax
as code owners
github-actions
bot
added
exporter/awscloudwatchlogs
bogdandrutu
force-pushed
the
rm-opencensus-goleak
branch
2 times, most recently
from
b7e9ca8
to
54ac233
Compare
bogdandrutu
commented
Oct 4, 2024
| ignore: | ||
| top: | ||
| # See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
| - "go.opencensus.io/stats/view.(*worker).start" |
There was a problem hiding this comment.
I got confused, this says that I added new line, and removed the "no new line".
bogdandrutu
force-pushed
the
rm-opencensus-goleak
branch
from
54ac233
to
d845508
Compare
dashpole
approved these changes
Oct 4, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rm-opencensus-goleak
branch
from
d845508
to
718b034
Compare
crobert-1
approved these changes
Oct 4, 2024
crobert-1
added
the
ready to merge
songy23
approved these changes
Oct 4, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…try#35625) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…try#35625) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.