[cmd/opampsupervisor]: update defult output paths for supervisor logger #36072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
evan-bradley and
tigrannajaryan
|
I think we should have a changelog to call out changing logging to be done on stderr. |
evan-bradley
approved these changes
Oct 31, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/not-stale |
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…er (open-telemetry#36072) Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…er (open-telemetry#36072) Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…er (open-telemetry#36072) Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the default output path to
stderr, consistent with other components. Otherwise, the same logs appear twice. Not sure if this requires a changelog.Link to tracking issue
Fixes
Testing
Documentation