Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [receiver/splunkhec] Remove duplicate constructor #36083

Merged

Conversation

dmitryax
Copy link
Member

Reduce code duplication and remove redundant check for nil next consumer which is done in the receiverhelper.

@dmitryax dmitryax marked this pull request as ready for review October 29, 2024 23:16
@dmitryax dmitryax requested review from atoulme and a team as code owners October 29, 2024 23:16
@dmitryax dmitryax force-pushed the remove-duplicate-code-hec-receiver branch from 667dce0 to 18fa064 Compare October 29, 2024 23:26
Reduce code duplication and remove redundant check for nil next consumer which is done in the receiverhelper.
@dmitryax dmitryax force-pushed the remove-duplicate-code-hec-receiver branch from 18fa064 to 5141648 Compare October 29, 2024 23:42
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit fc8132c into open-telemetry:main Oct 30, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
@dmitryax dmitryax deleted the remove-duplicate-code-hec-receiver branch October 30, 2024 01:44
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this pull request Nov 12, 2024
…etry#36083)

Reduce code duplication and remove redundant check for nil next consumer
which is done in the receiverhelper.
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…etry#36083)

Reduce code duplication and remove redundant check for nil next consumer
which is done in the receiverhelper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants