[receiver/awsfirehose] follow receiver contract #36124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
approved these changes
Nov 7, 2024
|
@open-telemetry/collector-contrib-approvers @andrzej-stencel can this be merged? |
|
@Aneurysm9 could you also take a look? |
|
I'd be happy to merge it, but I'd like to mark it as a breaking change, as the change in the returned HTTP codes can potentially break some users' setups. @VihasMakwana can you make the change to the changelog entry? |
|
@andrzej-stencel done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables awsfirehose to follow the receiver contract and maintain the correct order of operations. The status code returned by the receiver should be dependent upon type of error (i.e. permanent/non-permanent error)