Fix quick start bug within the awsxrayreceiver #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
May 26, 2021
bogdandrutu
requested changes
May 26, 2021
|
@anuraaga @Aneurysm9 please review |
anuraaga
approved these changes
May 27, 2021
bogdandrutu
reviewed
May 27, 2021
receiver/awsxrayreceiver/receiver.go
Outdated
| @@ -117,6 +117,7 @@ func (x *xrayReceiver) Shutdown(_ context.Context) error { | |||
| func (x *xrayReceiver) start() { | |||
| incomingSegments := x.poller.SegmentsChan() | |||
| for seg := range incomingSegments { | |||
| seg.Ctx = x.obsrecv.StartTraceDataReceiveOp(seg.Ctx) | |||
There was a problem hiding this comment.
ctx := x.obsrecv.StartTraceDataReceiveOp(seg.Ctx)
Every operation starts from seg.Ctx not from previous returned.
There was a problem hiding this comment.
Changed in the latest commit
Aneurysm9
approved these changes
Jun 1, 2021
bogdandrutu
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix bug within the awsxrayreceiver where the start func was not called.