Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug_fix] [exporter/pulsar] Change configuration option #36579

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

liuby01
Copy link
Contributor

@liuby01 liuby01 commented Nov 28, 2024

Description

I updated the name of the item map_connections_per_broker in the config and description in readme. Changed from map_connections_per_broker to max_connections_per_broker. From the description of the item in readme, I think this should be a typo.

@liuby01 liuby01 requested review from dmitryax and a team as code owners November 28, 2024 07:18
Copy link

linux-foundation-easycla bot commented Nov 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bugfix, can you please add a changelog to note the change in config option

@liuby01 liuby01 changed the title [chore] [exporter/pulsar] Update config item name [bug_fix] [exporter/pulsar] Change configuration option Dec 3, 2024
@liuby01
Copy link
Contributor Author

liuby01 commented Dec 3, 2024

This looks like a bugfix, can you please add a changelog to note the change in config option

Of course, I've added changelog.

@liuby01 liuby01 requested a review from codeboten December 3, 2024 03:06
@dmitryax dmitryax merged commit 2ee18d0 into open-telemetry:main Dec 3, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 3, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
…ry#36579)

#### Description
I updated the name of the item `map_connections_per_broker` in the
config and description in readme. Changed from
`map_connections_per_broker` to `max_connections_per_broker`. From the
description of the item in readme, I think this should be a typo.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…ry#36579)

#### Description
I updated the name of the item `map_connections_per_broker` in the
config and description in readme. Changed from
`map_connections_per_broker` to `max_connections_per_broker`. From the
description of the item in readme, I think this should be a typo.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants