Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadogexporter] Add support for summary datatype #3660

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 27, 2021

Description:

Add support for summary datatype to the Datadog exporter.

Since this is a datatype that is used mostly for compatibility with OpenMetrics, the implementation largely follows the features on our existing OpenMetrics base check on the Datadog Agent.

Link to tracking Issue: Fixes #3154

Testing: Added unit tests.

Documentation: Documented report_quantiles flag

@mx-psi mx-psi force-pushed the mx-psi/add-summary-type branch from 38281c7 to 8984957 Compare May 28, 2021 08:16
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exporter/datadogexporter/metrics_translator.go Outdated Show resolved Hide resolved
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
@mx-psi mx-psi marked this pull request as ready for review June 1, 2021 13:39
@mx-psi mx-psi requested a review from a team June 1, 2021 13:39
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Jun 1, 2021
@bogdandrutu bogdandrutu merged commit 434f9f3 into open-telemetry:main Jun 1, 2021
@mx-psi mx-psi deleted the mx-psi/add-summary-type branch June 2, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataDog exporter doesn't export ValueRecorder metrics
5 participants